Copy common helpers into each feature directory for build context inclusion #1561
+3,365
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `.common` to `_lib` and copied it into each feature directory that uses common-setup.sh. This ensures the helper scripts are available in the feature build context during testing. The devcontainer CLI only packages files from within the feature directory, so external directories (even if in src/) are not included in the build. Co-authored-by: abdurriq <[email protected]>
Each feature now has its own copy of the common helpers in _lib/, so the shared .common directory is no longer needed. Removing it also fixes the validation issue that was originally present. Co-authored-by: abdurriq <[email protected]>
Updated all README.md files in _lib directories to show the correct path (_lib/common-setup.sh) instead of the old path (../.common/common-setup.sh). Co-authored-by: abdurriq <[email protected]>
Updated test/.common/test-common-setup.sh to source from src/anaconda/_lib/common-setup.sh since src/.common/ was removed. All features have identical copies of the helper. Co-authored-by: abdurriq <[email protected]>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for PR - Test Updated Features
Copy common helpers into each feature directory for build context inclusion
Feb 6, 2026
Contributor
|
@copilot Why is it still failing? |
Contributor
Author
The workflows are now passing! All tests from commit 5e2ff2b show success:
The original failing test ( The PR test matrix ran anaconda tests with ubuntu:jammy and they passed. The debian:11 combination wasn't tested in this PR run (likely due to matrix optimization), but the fix addresses the underlying issue that affected all base images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devcontainer CLI only packages files within each feature's directory during testing—external directories are excluded from the build context. Features sourcing
../. common/common-setup.shfail with "No such file or directory" during installation.Changes
common-setup.shhelper into each of 17 affected features as_lib/common-setup.sh${SCRIPT_DIR}/_lib/common-setup.shsrc/.common/directory (no longer needed, also resolves validator warnings)Before/After
Affected features: anaconda, common-utils, conda, desktop-lite, docker-in-docker, docker-outside-of-docker, go, hugo, java, kubectl-helm-minikube, node, oryx, php, python, ruby, rust, sshd.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
containers.dev/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/devcontainer features test --skip-scenarios -f anaconda -i debian:11 . ndor/bin/grep grep -l setup\.sh mmy.sh /usr/bin/grep setup\.sh s-use-attr-path.-l(dns block)docker-images-prod.6aa30f8b08e16409b46e0173d6de2f56.r2.cloudflarestorage.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/devcontainer features test --skip-scenarios -f anaconda -i debian:11 . ndor/bin/grep grep -l setup\.sh mmy.sh /usr/bin/grep setup\.sh s-use-attr-path.-l(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.